[Bug 745455] dashdemux: doesn't take the presentationTimeOffset into account.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745455

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298996|committed                   |needs-work
             status|                            |

--- Comment #31 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 298996:
 --> (https://bugzilla.gnome.org/review?bug=745455&attachment=298996)

You should provide a default implementation that just returns 0 so that
mssdemux and hlsdemux won't crash/assert.

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +1396,3 @@

+  if (GST_BUFFER_PTS (buffer) != GST_CLOCK_TIME_NONE)
+    GST_BUFFER_PTS (buffer) += offset;

How about moving this to when the PTS is set on the buffer a few lines above?

Makes easier to read the code as the PTS is set only once and is not modified
anymore.

You can also only call the get_presentation_offset function inside the
'first_fragment_buffer' if as it would only be used there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.