[Bug 746017] audiodecoder: Take into account subclass PTS if provided

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Mar 11 03:18:36 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746017

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299078|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299078:
 --> (https://bugzilla.gnome.org/review?bug=746017&attachment=299078)

Why would the timestamp ever be different than the timestamp of the oldest
pending frame?

I think the problem here is more that the subclass does not use the base class
properly... erm... I mean that the base class does too many assumptions and
requires the subclass to do things in a very specific way (as described in the
other bug).

I think instead of this patch it would make more sense to unbreak the
timestamp/frame tracking code in the base class.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list