[Bug 729198] oggdemux: add non flushing time seeking to 0 in push mode

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Mar 11 07:48:40 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=729198

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #22 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
All comments addressed, remaining issues gone, make check passes. In it goes.

commit e77b60a73f7a879e67d6f8c6ca69479118eb87a8
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Thu Mar 5 17:42:53 2015 +0000

    oggdemux: do not send seek events from the streaming thread

    This will usually deadlock, despite this patch being in master for
    quite some time and working fine. Nevertheless, we deem it to be
    not working, disregarding facts.

    As such, we fix it by keeping track of seek events, and sending
    them upstream from a separate thread. Buffers are then discarded
    till we get a new segment with the expected seqnum.

commit 5f3fc5db058b3014d966944892cf0cef4656e859
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Feb 23 13:07:41 2015 +0000

    oggdemux: set correct seqnum on segment events after a seek in push mode

    There is already a seqnum field for this, which was used to overwrite
    the seqnum that was set by the push specific code.

commit acaf534714e380886ffc2f17b874513dd6ddafdc
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Feb 23 11:30:36 2015 +0000

    oggdemux: try harder to query duration from upstream

    READY->PAUSED can be too early as souphttpsrc can get the HTTP
    headers after this. Try again in the chain function.

    Also use seeking query to disable seeking if upstream reports
    being unseekable.

commit 969cf47a82823d71f53bb576048e5d228926c783
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Fri Oct 31 10:55:14 2014 +0000

    oggdemux: add non flushing time seeking in push mode

    Some resetting code has to be done in the NEW_SEGMENT
    event handler, instead of the missing FLUSH_STOP one.

    Segment base was also wrongly accounted for. This was hidden
    by the fact that flushing resets the base.

    A discontinuity is now also signalled on seeking. We have to
    also ensure that the discontinuity "sticks" till a buffer
    with a valid timestamp goes out, or the audio decoder base
    class will ignore the discontinuity for purposes of keeping
    track of the current time.

    This allows using non flushing segment seeks for looping
    HTML audio in particular, and more generally non flushing seeks.

    https://bugzilla.gnome.org/show_bug.cgi?id=729198

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list