[Bug 733351] queue2: Process SEEKING query

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733351

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290514|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 290514:
 --> (https://bugzilla.gnome.org/review?bug=733351&attachment=290514)

Mostly looks good, I would call that function something like
handle_seeking_query() or similar though.

::: plugins/elements/gstqueue2.c
@@ +2923,3 @@
+  if (segment_end <= segment_start) {
+    GST_DEBUG_OBJECT (queue, "no range to seek");
+    return FALSE;

I think this should not fail the query but just set it to unseekable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.