[Bug 746012] gl: add GstGLDisplayCocoa to handle NSApp initialization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746012

--- Comment #4 from Julien Isorce <julien.isorce at gmail.com> ---
[16:46] <capOM> The goal was actually to make it less complicated. And it is
not to work around a bug it is because it should not be handled by
GstGLContext, but display.  Because it is not 1:1 with GLContext. Then I just
added in the patch a way to workaround acquire/release.
[16:47] <slomo> but there is not really a GstGLDisplayCocoa
[16:47] <slomo> there is nothing like a display there
[16:47] <slomo> so it seems weird to just add a display for the workaround
thing
[16:47] <capOM> Well the apple doc says it initialize the display env
[16:48] <slomo> yes, but there's only a single "display"
[16:48] <slomo> you don't even have a handle or anything for it
[16:49] <slomo> and once that bug is fixed in glib in one way or another, the
GstGLDisplayCocoa would just be empty
[16:51] <capOM> Yeah it is an overall display. And yep it would be empty as all
the code currently in gstglcontextcocoa is under this ifndef
[16:51] <capOM> well if glib has the fix soon I will be more than happy
[16:51] <slomo> it probably won't be soon :) but we have a fix in cerbero
[16:52] <capOM> The thing is I am not using cerbero but mac ports with
gst-uninstalled
[16:52] <slomo> so if you say the code is simpler now, and also better... just
push it and i look away ;)
[16:52] <slomo> but please don't make things more complicated, and also
GstGLDisplayCocoa shouldn't be public API
[17:02] <capOM> oups I was distracted, ok I'll make it not public at least. And
it is roughly same code as current, except it is in a separate file.  Later
even if this file will be empty, it could still be a place to do some stuff
that are not 1:1 to a context when shared with several context.
[17:03] <slomo> ok :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.