[Bug 736655] basesink: preroll issue for some clips which audio is shorter than video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=736655

--- Comment #153 from kevin <kevinbing.song at gmail.com> ---
(In reply to Wim Taymans from comment #151)
> commit 4b174b14f51b4d405674c0d1054e82f5dbc82094
> Author: Wim Taymans <wtaymans at redhat.com>
> Date:   Wed Mar 11 16:36:29 2015 +0100
> 
>     basesink: clean up the need_preroll variable
>     
>     Based on patch from Song Bing <b06498 at freescale.com>
>     
>     Don't just set the need_preroll flag to TRUE in all cases. When we
>     are already prerolled it needs to be set to FALSE and when we go to
>     READY we should not touch it. We should only set it to TRUE in other
>     cases, like what the code above does.
>     
>     See https://bugzilla.gnome.org/show_bug.cgi?id=736655

The patch has issue. sink can't pause after state change from PLAYING to
PAUSED. Will upload basesink log later.
Reproduce step:
1. revert below commit. so unit test will hang on wait async-done event. and
then unit test timeout.
2. check log of basesink. basesink hasn't been paused.

commit 1942870257747290c0d64a09e1a0d25bd296f8c6
Author: Song Bing <b06498 at freescale.com>
Date:   Tue Mar 3 15:18:04 2015 +0800

    streamsynchronizer: Should wait state change complete before start another
state change

    Should wait state change complete before start another state change.
    Can't ensure can received async-done message when state change from PLAYING
to PAUSED.

    https://bugzilla.gnome.org/show_bug.cgi?id=736655

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.