[Bug 722129] mpegtsmux: alignment property does not work as expected for UDP streaming

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Mar 15 05:13:24 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=722129

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1
            Summary|mpegtsmux: alignment        |mpegtsmux: alignment
                   |property does not work      |property does not work as
                   |                            |expected for UDP streaming

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
We decided to change the behaviour of the "alignment" property instead:

commit ab52bfbfa6ba80162204b0b7f89a03f70613423e
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sun Mar 15 12:06:22 2015 +0000

    tests: mpegtsmux: add unit test for "alignment" property

    https://bugzilla.gnome.org/show_bug.cgi?id=722129

commit 09c05df8896db8859483c3aa70228aab87b5047c
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sat Mar 14 15:27:39 2015 +0000

    mpegtsmux: make "alignment" property more useful for packetisation

    Currently the alignment property just makes sure that we
    output things in multiples of align*packet_size bytes, but
    with no clear maximum size. When streaming MPEG-TS over
    UDP one wants buffers with a maximum packet size of 1316.
    The alignment property so far would just output buffers
    that are a multiple of 1316 then.

    Instead we now make the alignment property output
    individual buffers with the alignment size, which
    is entirely backwards compatible with the expected
    behaviour up until now. For efficiency reason
    collect all those buffers in a buffer list and
    send that downstream.

    Also collect data to push downstream in a buffer
    list from the adapter if we don't align things,
    which is still more efficient because of the
    silly way the muxer currently creates output
    packets.

    https://bugzilla.gnome.org/show_bug.cgi?id=722129

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list