[Bug 746274] flvdemux: Less spam from no_more_pads warning

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746274

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299496|none                        |needs-work
             status|                            |

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 299496:
 --> (https://bugzilla.gnome.org/review?bug=746274&attachment=299496)

Looks good except for these small details. Though, I'm wondering why is this a
warning is the first place ? Can't an FLV be audio or video only ?

::: gst/flv/gstflvdemux.c
@@ +925,3 @@
   GST_LOG_OBJECT (demux, "parsing an audio tag");

+  if G_UNLIKELY (!demux->audio_pad && demux->no_more_pads) {

Add ifndef GST_DISABLE_DEBUG here, so we don't have this if if there is not
debug.

@@ +1328,3 @@
   GST_LOG_OBJECT (demux, "parsing a video tag");

+  if G_UNLIKELY (!demux->video_pad && demux->no_more_pads) {

same.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.