[Bug 679768] mpegaudioparse, baseparse: fix tag handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=679768

--- Comment #15 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 263181
  --> https://bugzilla.gnome.org/attachment.cgi?id=263181
baseparse: Add Tag handling

I think the way these tags are handled here is all wrong (I realise it's
modelled on the audio/video decoder code, but that also doesn't seem right to
me).

As I see it, we should maintain a copy of the upstream tags (latest version),
and then the parser tags plus merge mode separately. The parser tags replace
any previous parser tags if updated.

Whenever upstream tags change or the parser tags are set, we do
tags_changed=TRUE (which should be renamed to update_tags or resend_tags or
something).

Just merging continuously into previous merge results seems a bit weird to me.

>+void
>+gst_base_parse_merge_tags (GstBaseParse * parse, const GstTagList * tags,
>+    GstTagMergeMode mode)

I think something like gst_base_parse_set_parser_tags() would be clearer, but
don't mind merge_tags() for consistency if others prefer that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.