[Bug 746147] compositor: Don't convert or aggregate pads that are completely obscured by a higher zorder pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746147

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299660|none                        |reviewed
             status|                            |

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 299660:
 --> (https://bugzilla.gnome.org/review?bug=746147&attachment=299660)

::: gst/compositor/compositor.c
@@ +301,3 @@
+static gboolean
+is_rectangle_obscured (gint x11, gint y11, gint x12, gint y12, gint x21,
+    gint y21, gint x22, gint y22)

The naming is cryptic. Grouping the rectangles in a structure would be much
cleaner. I found that outside of the compositor we tend to use rectangle as a
point and a size instead of two points. It is not very consistent, fixing it
would allow create some utility to eventually implement a proper rectangle
based render. See GstVideoRectangle in gstvideosink.h as an example for a
structure (we could reuse this one already).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.