[Bug 746147] compositor: Don't convert or aggregate pads that are completely obscured by a higher zorder pad

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Mar 17 16:24:33 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746147

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299661|none                        |accepted-commit_now
             status|                            |

--- Comment #9 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 299661:
 --> (https://bugzilla.gnome.org/review?bug=746147&attachment=299661)

This looks good.

::: gst/compositor/compositor.c
@@ +339,3 @@
     width = cpad->width;
   else
+    width = pad->info.width;

I'm not big fan of the accessor macros either, but I would recommend to make
sure not using them here is fully concistent. The macro would have been
GST_VIDEO_INFO_WIDTH()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list