[Bug 746147] compositor: Don't convert or aggregate pads that are completely obscured by a higher zorder pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746147

--- Comment #12 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
> (In reply to Nicolas Dufresne (stormer) from comment #10)
> > Review of attachment 299662 [details] [review] [review]:
> > 
> > Test looks good in general, the GstVideoMeta::map() trick is neat.
> > 
> > ::: tests/check/elements/compositor.c
> > @@ +1253,3 @@
> > +  buffer_mapped = FALSE;
> > +
> > +  alpha1 = g_rand_double_range (rand, 0.1, 0.9);
> > 
> > Using unseeded GRand seems like a bad idea. Do you really need random values
> > here ?
> 
> From the GLib documentation:
> 
> > g_rand_new()
> > 
> >Creates a new random number generator initialized with a seed taken either from /dev/urandom (if existing) or from the current time (as a fallback).
> 
> So, the seed is probably better than anything we could give it!

Also, I thought it would be a good idea to test random alpha values just in
case one of them causes something stupid sometime in the future. Not really
essential.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.