[Bug 746011] gstpad : refactor gst_pad_link_prepare function
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Mar 17 17:39:00 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=746011
Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #299082|none |needs-work
status| |
--- Comment #4 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 299082:
--> (https://bugzilla.gnome.org/review?bug=746011&attachment=299082)
Unlocking at the end of
::: gst/gstpad.c
@@ +2350,3 @@
+ GST_OBJECT_LOCK (srcpad);
+ GST_OBJECT_LOCK (sinkpad);
You can't unlock in gst_pad_link_prepare() and re-lock here, stuff may have
changed in between. How to make this more simple is not obvious to me, and I
assume was not obvious to the person who wrote this.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list