[Bug 746387] Add support for buffer list in srtpenc and srtpdec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746387

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299691|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299691:
 --> (https://bugzilla.gnome.org/review?bug=746387&attachment=299691)

::: ext/srtp/gstsrtpenc.c
@@ +985,1 @@
   do_setcaps = filter->key_changed;

Doesn't this need some locking?

@@ +1118,2 @@
   if (gst_srtp_get_soft_limit_reached ()) {
     g_signal_emit (filter, gst_srtp_enc_signals[SIGNAL_SOFT_LIMIT], 0);

Holding the lock while emitting a signal is not a great idea

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.