[Bug 746387] Add support for buffer list in srtpenc and srtpdec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746387

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299695|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299695:
 --> (https://bugzilla.gnome.org/review?bug=746387&attachment=299695)

::: ext/srtp/gstsrtpdec.c
@@ +1214,3 @@
+  /* If all is well, we may have reached soft limit */
+  if (gst_srtp_get_soft_limit_reached ())
+    request_key_with_signal (filter, ssrc, SIGNAL_SOFT_LIMIT);

Emitting a signal with a mutex locked is not great

@@ +1217,3 @@
+
+push_out:
+  /* Push buffer list to source pad */

And all here must be done without holding the mutex, you also forget to unlock
it before returning

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.