[Bug 746387] Add support for buffer list in srtpenc and srtpdec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746387

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299720|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299720:
 --> (https://bugzilla.gnome.org/review?bug=746387&attachment=299720)

::: ext/srtp/gstsrtpdec.c
@@ +1201,3 @@
+      GST_OBJECT_UNLOCK (filter);
+      GST_WARNING_OBJECT (filter, "Invalid buffer, dropping");
+      goto drop_buffers;

Maybe if there are invalid buffers, just drop the invalid ones but continue
processing the others. (Same in the encoder btw)

@@ +1217,3 @@
+      goto drop_buffers;
+    }
+    GST_OBJECT_UNLOCK (filter);

You're unlocking here in every iteration, that's not going to work.

@@ +1222,3 @@
+  /* If all is well, we may have reached soft limit */
+  if (gst_srtp_get_soft_limit_reached ())
+    request_key_with_signal (filter, ssrc, SIGNAL_SOFT_LIMIT);

And holding the lock while emitting the signal here. I assume the unlock
should've been below the loop?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.