[Bug 738216] audiomixer: segfault with rtp and audiotestsrc mixing buffers

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Mar 19 04:54:07 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=738216

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299800|none                        |needs-work
             status|                            |

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 299800
  --> https://bugzilla.gnome.org/attachment.cgi?id=299800
add gst_segment_are_equal

Ah yes, I noticed these too in the gst-plugins-base unit tests. This won't
cause any crashes though.

For the patch:

 - should be called gst_segment_is_equal()

 - please just write out the comparisons instead of that macro

 - should be Since: 1.6

 - could also get the offset of  _gst_reserved and do memcmp up until that, but
perhaps explicit compare is nicer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list