[Bug 740575] Fixing DTS in GStreamer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=740575

--- Comment #44 from Wim Taymans <wim.taymans at gmail.com> ---
> When synching on DTS (e.g. decoding sync, or identity sync=1) it would be
> unfortunate if we would be dropping a buffer because it's outside of the
> segment. There is no way to actually know, so if it's before, we need to
> render it from now on. I'm not sure if that is even consistent in any
> direction across the code.

Yes, so in that case it's better to use the offset and not allow DTS before the
segment start. If you get a valid DTS that is negative, you would render it
ASAP, which is what the current behaviour is.

Allowing valid DTS before the segment start is probably not a good idea on
second thought.

> 
> In any case, it is needed, otherwise we can't calculate the offset, which
> must be in running time. The easy way is to get the DTS and PTS in running
> time, and substract it (if DTS the absolute of a negative value, add it).

You can do that with the current gst_segment_to_running_time_full(). What are
you suggesting we do differently? Or did you mean to say that you would need a
different method if we would ever allow invalid DTS being treated as valid?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.