[Bug 746524] queue: Add property to allow pushing all queued buffers together

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Mar 20 10:11:28 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746524

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299946|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299946:
 --> (https://bugzilla.gnome.org/review?bug=746524&attachment=299946)

Generally looks good to me, but I think the impact of this will be not too big.
It would only cause different behaviour if the queue is blocked long enough to
accumulate more than one buffer.

::: plugins/elements/gstqueue.c
@@ +130,3 @@
 #define DEFAULT_MAX_SIZE_TIME     GST_SECOND    /* 1 second    */

+#define DEFAULT_GENERATE_BUFFER_LIST FALSE

You should initialize the struct field to that in gst_queue_init()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list