[Bug 746617] opusenc: headers are never sent

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746617

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300088|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 300088:
 --> (https://bugzilla.gnome.org/review?bug=746617&attachment=300088)

Good catch :)

::: ext/opus/gstopusenc.c
@@ +984,3 @@
         gst_tag_setter_get_tag_list (GST_TAG_SETTER (enc)));

+    gst_audio_encoder_set_headers (benc, enc->headers);

This function takes ownership of the list of headers. The pointer is not valid
anymore afterwards, so you would either need to deep-copy the list or set
enc->headers to NULL

-- 
You are receiving this mail because:
You are the QA Contact for the bug.