[Bug 746617] opusenc: headers are never sent

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746617

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Ilya Konstantinov from comment #4)
> I agree. I also thought it strange that opusdec gives a single chance for
> the header to be present in the first packet, given that transport can be
> unreliable.

(note that other codecs like h264 or even Vorbis put the headers into the SDP
for that reason...)

> In OpenWebRTC, GstRTPOpusDepay gets 'application/x-rtp; ... channels:1' but
> this information isn't forwarded to GstOpusDec in any way.
> 
> Perhaps GstOpusDec should allow the fallback values to be configurable via
> properties?

The SDP fields should become caps fields in application/x-rtp, which then are
transformed by the depayloader in caps fields in audio/x-opus. Then the decoder
can do something useful with them.

It seems like the Opus payloader and depayloader completely ignore all the SDP
fields mentioned in the RFC.

> (In reply to Sebastian Dröge (slomo) from comment #2)
> > This function takes ownership of the list of headers. The pointer is not
> > valid anymore afterwards, so you would either need to deep-copy the list or
> > set enc->headers to NULL
> 
> I'll just set it to NULL and eliminate all of the unrefs.

I think the headers are also used to put them into the caps. They might still
be needed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.