[Bug 746632] dispmanx: surfaceless EGL context support broken

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746632

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300143|none                        |reviewed
             status|                            |

--- Comment #8 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 300143:
 --> (https://bugzilla.gnome.org/review?bug=746632&attachment=300143)

Thx for the patch, it looks good, I just put a few remarks.

::: gst-libs/gst/gl/dispmanx/gstglwindow_dispmanx_egl.c
@@ +40,3 @@
+#define ELEMENT_CHANGE_TRANSFORM      (1<<5)
+#endif
+

I guess it was not working to include vc_vchi_dispmanx.h ?

@@ +370,2 @@
   }


Just a detail :) :
You can remove this "if () window_resize" block as it is done in show. And to
be close as what gstglwindow_x11.c does.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.