[Bug 746682] flvdemux: Don't create AAC/H264 caps without codec_data

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746682

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300192|none                        |reviewed
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 300192:
 --> (https://bugzilla.gnome.org/review?bug=746682&attachment=300192)

::: gst/flv/gstflvdemux.c
@@ +714,1 @@
+      gst_buffer_map (demux->audio_codec_data, &map, GST_MAP_READ);

Check the return value while at it please.

@@ +932,3 @@

+  if G_UNLIKELY
+    (!demux->audio_pad && demux->no_more_pads) {

This is a weird syntax, I didn't know it was valid. Remains that his change
does not belong here.

@@ +1116,3 @@
+          GST_ERROR_OBJECT (demux, "got AAC audio packet before codec data");
+          ret = GST_FLOW_ERROR;
+          goto beach;

Is that an error without posting on the bus ? Or is this only failing audio ?
Maybe posting at least a warning on the bus would be nice ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.