[Bug 736891] input-selector: Can't unblock after emitting a "block" signal

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Mar 24 06:11:33 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=736891

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |thiagossantos at gmail.com
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #8 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Thanks for the patches, fixed.

commit 0a3ded193278ad95b04ace3dc5e2fcf7e277abff
Author: Jan Alexander Steffens (heftig) <jsteffens at make.tv>
Date:   Mon Mar 23 13:20:34 2015 +0100

    input-selector: Remove 'blocked' flag

    With the disappearance of the 'block' signal, this
    flag cannot be set to TRUE.

    gst_input_selector_wait disappears as it never waits
    and just returns self->flushing.

    https://bugzilla.gnome.org/show_bug.cgi?id=736891

commit 7a1ebbe0e3a19c4e2108ddbb50095add3d265d9d
Author: Jan Alexander Steffens (heftig) <jsteffens at make.tv>
Date:   Mon Mar 23 12:12:51 2015 +0100

    input-selector: Remove obsolete 'block' signal

    This signal blocks the input-selector with no means of unblocking
    other than a state change back to READY. It seems this signal was
    part of an old way of synchronously switching the selector,
    together with the already-removed 'switch' signal.

    Removing the signal is safe, as attempting to use it could only
    end in deadlocks. Attempting to emit an unknown signal just causes
    g_criticals.

    https://bugzilla.gnome.org/show_bug.cgi?id=736891

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list