[Bug 739620] input-selector: _activate_sinkpad conflates two different functions

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739620

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |thiagossantos at gmail.com
         Resolution|---                         |FIXED

--- Comment #9 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Pushed, thanks.

commit 27644a6bd2ca96cf6e02a7508c31e89d5389113b
Author: Jan Alexander Steffens (heftig) <jsteffens at make.tv>
Date:   Wed Nov 19 13:08:45 2014 +0100

    input-selector: Rename _activate_sinkpad to _get_active_sinkpad

    Removes the now unused 'pad' parameter and renames the function
    to something more appropriate.

    https://bugzilla.gnome.org/show_bug.cgi?id=739620

commit bf8a71104c70faab0cf03ab94f4fd94bb22e5e1f
Author: Jan Alexander Steffens (heftig) <jsteffens at make.tv>
Date:   Wed Nov 19 13:03:21 2014 +0100

    input-selector: Remove pad's 'active' field

    This is now never read.

    https://bugzilla.gnome.org/show_bug.cgi?id=739620

commit 6f24f4917d6cdde5cdb6935f3ff6eb21948c714b
Author: Jan Alexander Steffens (heftig) <jsteffens at make.tv>
Date:   Wed Nov 19 12:59:12 2014 +0100

    input-selector: Use segment-presence for running_time check

    When determining whether the running_time of a pad can be
    calculated, check if the segment is in TIME format instead
    of using the 'active' field.

    Since the latter is set through *any* activity, it's not a
    reliable indicator of segment presence.

    https://bugzilla.gnome.org/show_bug.cgi?id=739620

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.