[Bug 746661] audioconvert is slow on architectures without 64-bit integer divide (e.g. armv7)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746661

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300167|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 300167:
 --> (https://bugzilla.gnome.org/review?bug=746661&attachment=300167)

::: gst/audioconvert/gstaudioquantize.c
@@ +173,3 @@
 #define ADD_DITHER_TPDF_I()                                             \
+        rand = bias + RANDOM_INT_DITHER(dither)                         \
+                    + RANDOM_INT_DITHER(dither);                        \

This is wrong now, see INIT_DITHER_TPDF_I(). It was halving the bias, and then
adding it here twice. It's still halving now but you only add the bias once
now. Just change it in INIT_DITHER_TPDF_I().

@@ -169,3 @@
 #define ADD_DITHER_TPDF_I()                                             \
-        rand = gst_fast_random_int32_range (bias - dither,              \
-                   bias + dither - 1)                                   \

The -1 here is very curious, I don't know yet where it comes from. It doesn't
seem to make any sense.

@@ +198,1 @@
         rand = tmp_rand - last_random[chan_pos];                        \

Note that here you have bias twice again. Once in tmp_rand, once in
last_random[chan_pos]. Maybe just add the bias once, and not have it in
last_random[chan_pos]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.