[Bug 746617] opusenc: headers are never sent

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746617

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300218|none                        |needs-work
             status|                            |

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 300218
  --> https://bugzilla.gnome.org/attachment.cgi?id=300218
opusenc: Forward channel count preferences from downstream to source

gst_audio_encoder_proxy_getcaps() should already do that, with less code.


For the multistream stuff, it doesn't look like it's properly implemented
currently. In the encoder it needs some better channel-layout handling
(currently it just fails to handle any non-Vorbis channel layout but doesn't
put that on the caps), in the decoder we don't have any multistream handling at
all AFAIU. I would prefer to keep channels=[1,2] until that is fixed.

Also I think we should put the channel mappings and other things (the stuff
that is stored in the first Ogg header) into the audio/x-opus caps. They are
needed by the decoder to properly decode multistream Opus (unless the caps
contain the Ogg specific header).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.