[Bug 745441] v4l2: Detect lossed frame and warn

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745441

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300279|none                        |needs-work
             status|                            |

--- Comment #17 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 300279:
 --> (https://bugzilla.gnome.org/review?bug=745441&attachment=300279)

::: sys/v4l2/gstv4l2src.c
@@ +815,3 @@
+  } else {
+    /* check for frame loss with given (from v4l2 device) buffer offset */
+    if ((GST_BUFFER_OFFSET (*buf) != (v4l2src->offset + 1)) &&
(v4l2src->offset != 0)) {

Could you use OFFSET_END to avoid the +1 ? And maybe check offset != 0 before ?

@@ +827,3 @@
+
+    }
+    v4l2src->offset = GST_BUFFER_OFFSET (*buf);

Cool, but we need to reset the offset everything we reset the HW. Otherwise
we'll send a false positive on every renegotiation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.