[Bug 744209] rtspsrc can not keep rtsp alive

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744209

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300370|none                        |reviewed
             status|                            |

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 300370
  --> https://bugzilla.gnome.org/attachment.cgi?id=300370
rtspconnection: Fix timeout handling

>+    /* Timeout period have expired already */
>+    if (to == 0)
>+      return GST_RTSP_ETIMEOUT;
>+  }
>+
>   g_socket_client_set_timeout (conn->client,
>       (to + GST_SECOND - 1) / GST_SECOND);

Hrm, it's not clear to me that this is correct, if it should really not even
attempt to read any data here. That would be a bit like changing
gst_bus_timed_pop() to always return NULL if timeout is 0 even if there's a
pending message, no?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.