[Bug 745955] [gleffects] port all effects to GLES2

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745955

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299414|none                        |needs-work
             status|                            |

--- Comment #3 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 299414:
 --> (https://bugzilla.gnome.org/review?bug=745955&attachment=299414)

In addition to the remarks, I compared all the 16 effects between gles2 and
opengl:

GST_GL_API=opengl GST_GL_PLATFORM=glx
gst-launch-1.0 videotestsrc ! glupload ! gleffects effect=$i ! glimagesink

GST_GL_API=gles2  GST_GL_PLATFORM=egl
gst-launch-1.0 videotestsrc ! glupload ! gleffects effect=$i ! glimagesink

Everything it's fines except xpro which is wrong on gles2.

::: ext/gl/effects/gstgleffectbulge.c
@@ +29,3 @@
+#define USING_GLES2(context) (gst_gl_context_check_gl_version (context,
GST_GL_API_GLES2, 2, 0))
+#define USING_GLES3(context) (gst_gl_context_check_gl_version (context,
GST_GL_API_GLES2, 3, 0))
+

I think it is safe to put this in existing file gstgleffect.h

@@ +64,3 @@
+      return;
+    }
+#endif

for this "lookup/if(!share)/GLES2/OPENGL3/OPENGL/endif" block you could provide
a helper function in gstgleffect.h

::: ext/gl/gstgleffects.c
@@ +120,3 @@
     {0, NULL, NULL}
   };


Just remove GST_GL_HAVE_OPENGL guard.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.