[Bug 746887] gstmpeg2dec: fix a couple of leaks.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Mar 27 06:49:20 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746887

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300448|none                        |reviewed
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 300448:
 --> (https://bugzilla.gnome.org/review?bug=746887&attachment=300448)

::: ext/mpeg2dec/gstmpeg2dec.c
@@ +512,2 @@
   gst_buffer_replace (&in_frame->output_buffer, buffer);
+  gst_buffer_unref (buffer);

That wasting a ref/unref. Just do the if (blabla) unref, blabla = buffer dance
?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list