[Bug 745441] v4l2: Detect lossed frame and warn

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745441

--- Comment #19 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Peter Seiderer from comment #18)
> Not sure if the (micro) optimization to get rid of the '+1' code
> is justifying the minor code obfuscation (v4l2src->offset meaning changed
> from actual offset to expected offset)?

Ok I don't care much.

> 
> > 
> > @@ +827,3 @@
> > +
> > +    }
> > +    v4l2src->offset = GST_BUFFER_OFFSET (*buf);
> > 
> > Cool, but we need to reset the offset everything we reset the HW. Otherwise
> > we'll send a false positive on every renegotiation.
> 
> I have no example for renogotiation at the moment, does the  v4l2 driver
> reset the  sequence counter in case of renegotition?
> 
> If no: no need to reset v4l2src->offset, lost frame indication will stay...
> 
> If yes: I can take a look where to reset v4l2src->offset...


So ... I've asked Laurent P. He said that driver are supposed to restart the
sequence if you streamoff/streamon. While in GST you are not supposed to for
just a renegotiation. The sequence is only started if you actually flush the
pipeline.

So yes, this patch need a little more work to respect the GST contract when
their is a renegotiation (this is supported in v4l2src atm).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.