[Bug 746875] gstelement: Missing argument verification in gst_element_continue_state() and gst_element_change_state()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746875

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |WONTFIX
   Target Milestone|git master                  |NONE

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the patch, but these functions are mostly called internally, I see
no need to add these checks just for the sake of it.

Also, I am not sure what you mean by "so that user can handle it by setting
critical handler using g_log_set_handler()" - that just doesn't make sense to
me.

These checks are sanity checks for programmers to catch problems earlier. Once
one such check is triggered chances are things are not going to work afterwards
anyway, and on systems where GStreamer has been compiled with
-DG_DISABLE_CHECKS (or whatever the define is) it will just crash anyway.
Nothing should be handling these things programmatically at runtime really.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.