[Bug 679768] mpegaudioparse, baseparse: fix tag handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=679768

--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Tim-Philipp Müller from comment #15)
> Comment on attachment 263181 [details] [review]
> baseparse: Add Tag handling
> 
> I think the way these tags are handled here is all wrong (I realise it's
> modelled on the audio/video decoder code, but that also doesn't seem right
> to me).
> 
> As I see it, we should maintain a copy of the upstream tags (latest
> version), and then the parser tags plus merge mode separately. The parser
> tags replace any previous parser tags if updated.
> 
> Whenever upstream tags change or the parser tags are set, we do
> tags_changed=TRUE (which should be renamed to update_tags or resend_tags or
> something).
> 
> Just merging continuously into previous merge results seems a bit weird to
> me.

Agreed, and we should fixup the codec base classes too for this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.