[Bug 748529] adaptivedemux: only update stream position if query success
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue May 5 10:03:15 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=748529
--- Comment #6 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Thiago Sousa Santos from comment #3)
> Review of attachment 302493 [details] [review]:
>
> ::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
> @@ +1992,2 @@
> have_pos =
> gst_pad_peer_query_position (cur_stream->pad, GST_FORMAT_TIME,
>
> Perhaps we can eliminate the have_pos variable altogether and just put the
> pad query inside the if below. It looks easier to read IMHO.
Could you review my new patch? I upload new patch last week.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list