[Bug 743973] playbin: Need replace suburidecoderbin's segment with normal uridecoderbin's segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743973

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to kevin from comment #4)
> Add more information for the issue:
> 
> The issue only occur when application set appsink to playbin to sink
> subtitle. No such kind of issue if combine subtitle with video. Subtitle
> pipeline segment can't reach basesink as subtitle combined with video, so no
> such kind of issue.

This sounds like something would be wrong in
subtitleoverlay/assrender/textoverlay/etc too then. They should show the same
behaviour as a text-sink.




Also I think your patch is going to fail if the audio/video upstream is setting
a different base time, or otherwise has a non-standard segment. I think we need
to do something more clever here by actually not copying the segment... but
instead making sure that the subtitle segment is based on the audio/video
segment in a way that the first subtitle timestamp inside the segment is the
keyframe timestamp.

For this you would have to a) catch the audio/video segment and remember it, b)
*modify* the subtitle segment to adjust the start (and possibly other fields)
of the segment. The resulting subtitle segment should cause all subs to be
before the segment until the keyframe timestamp, the keyframe timestamp should
be mapped to running time 0 and to the stream time that the keyframe timestamp
also has for the audio/video segment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.