[Bug 749534] New: dashdemux: Some suspicious compiler warnings about checking if the unsigned segment index is smaller than 0

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749534

            Bug ID: 749534
           Summary: dashdemux: Some suspicious compiler warnings about
                    checking if the unsigned segment index is smaller than
                    0
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: major
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: slomo at coaxion.net
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

These probably cause reverse playback to fail in some way, and should probably
be fixed by making the segment index signed.



gstmpdparser.c:3731:31: error: comparison of unsigned expression < 0 is always
false
      [-Werror,-Wtautological-compare]
    if (stream->segment_index < 0)
        ~~~~~~~~~~~~~~~~~~~~~ ^ ~
gstmpdparser.c:3754:31: error: comparison of unsigned expression < 0 is always
false
      [-Werror,-Wtautological-compare]
    if (stream->segment_index < 0) {
        ~~~~~~~~~~~~~~~~~~~~~ ^ ~
gstmpdparser.c:3759:31: error: comparison of unsigned expression < 0 is always
false
      [-Werror,-Wtautological-compare]
    if (stream->segment_index < 0)
        ~~~~~~~~~~~~~~~~~~~~~ ^ ~
gstmpdparser.c:3784:33: error: comparison of unsigned expression < 0 is always
false
      [-Werror,-Wtautological-compare]
      if (stream->segment_index < 0) {
          ~~~~~~~~~~~~~~~~~~~~~ ^ ~
gstmpdparser.c:3908:52: error: comparison of unsigned expression >= 0 is always
true
      [-Werror,-Wtautological-compare]
    if (seg_idx < stream->segments->len && seg_idx >= 0)
                                           ~~~~~~~ ^  ~
5 errors generated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.