[Bug 749535] downloadbuffer: deadlock issue in playbin2

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749535

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303508|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 303508:
 --> (https://bugzilla.gnome.org/review?bug=749535&attachment=303508)

I'm not sure this mutex releasing and taking again is correct everywhere. Maybe
instead of that it would be cleaner to return the message from
update_buffering() and have it be posted by the caller once the mutex is
released for real.

::: plugins/elements/gstdownloadbuffer.c
@@ +1267,2 @@
             gst_structure_new ("GstCacheDownloadComplete",
                 "location", G_TYPE_STRING, dlbuf->temp_location, NULL)));

Here you're just posting another message while the mutex is locked :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.