[Bug 749690] splitfilesrc: Implement binary search in find_part_for_offset

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749690

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303773|none                        |needs-work
             status|                            |

--- Comment #2 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 303773:
 --> (https://bugzilla.gnome.org/review?bug=749690&attachment=303773)

::: gst/multifile/gstsplitfilesrc.c
@@ +374,3 @@
+{
+  if (part->start > *offset && part->stop < *offset)
+    return -1;

offset can't be both <= start and >= stop for a file part.

The match function should look like:

if (*offset > part->stop)
  return -1; /* The target is after this part */
if (*offset < part->start)
  return 1; /* The target is before this part */
return 0; /* This is the target part */

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.