[Bug 749916] videocrop: Make videocrop controllable

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749916

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304029|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 304029:
 --> (https://bugzilla.gnome.org/review?bug=749916&attachment=304029)

Please, provide a unit test. I have doubt that the locking is all correct,
though maybe when using a controller makes the changes atomic somehow (I don't
know the internal of the controller code).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.