[Bug 750033] basetransform - allow collation/separation of buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750033

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 304157:
 --> (https://bugzilla.gnome.org/review?bug=750033&attachment=304157)

I'm worried this is a partial solution to the need for a proper
AsyncBaseTransform.

::: libs/gst/base/gstbasetransform.h
@@ +93,3 @@
+  /* Default submit_input_buffer places the buffer here,
+   * for consumption by the generate_output method: */
+  GstBuffer      *queued_buf;

What if the element would like to handle it's own queue ?

@@ +279,3 @@
   GstFlowReturn (*transform_ip) (GstBaseTransform *trans, GstBuffer *buf);

+  GstFlowReturn (*submit_input_buffer) (GstBaseTransform *trans, gboolean
is_discont, GstBuffer *input);

Other similar API uses the term finish, though I'm not sure how to make that
fit. Why do you need the discount boolean ? Isn't the discont flag on the
buffer you submit enough ?

@@ +280,3 @@

+  GstFlowReturn (*submit_input_buffer) (GstBaseTransform *trans, gboolean
is_discont, GstBuffer *input);
+  GstFlowReturn (*generate_output) (GstBaseTransform *trans, GstBuffer
**outbuf);

generate or create (create seems more popular so far).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.