[Bug 750039] Keeping buffers with shared memory alive

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750039

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304174|none                        |reviewed
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 304174:
 --> (https://bugzilla.gnome.org/review?bug=750039&attachment=304174)

::: gst/gstbuffer.c
@@ +2228,3 @@
+ * Returns: The #GstParentBufferMeta that was added to the buffer
+ *
+ * Since: 1.5.1

Should be 1.6, same elsewhere.

@@ +2262,3 @@
+    if (!copy->region) {
+      /* only copy if the complete data is copied as well */
+      dmeta = gst_buffer_add_parent_buffer_meta (dest, smeta->buffer);

I'm not sure that this is right. Looking at gst_buffer_copy_into(), you may
have region = TRUE, but still have taken reference on the source buffer
memories.

Also, you could have region = FALSE, and not copy over the memory, or have
deeped copied that memory. In both cases, it make very little sense to keep the
source buffer alive.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.