[Bug 757419] openh264enc: add support for cabac entropy coding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757419

Nicola <lists at svrinformatica.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #314569|needs-work                  |none
             status|                            |
 Attachment #314569|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicola <lists at svrinformatica.it> ---
Created attachment 314628
  --> https://bugzilla.gnome.org/attachment.cgi?id=314628&action=edit
patch v2

here are the results with this patch:

gst-launch-1.0 -v videotestsrc ! openh264enc entropy-coding=1 ! fakesink

will produce h264 high profile

gst-launch-1.0 -v videotestsrc ! openh264enc entropy-coding=0 ! fakesink

will produce h264 baseline profile as before


gst-launch-1.0 -v videotestsrc ! openh264enc entropy-coding=1 !
video/x-h264,profile=baseline ! fakesink

will produce baseline profile and entropy coding is resetted to CAVLC with this
log

baseline profile requested in downstream caps, entropy codec resetted to CAVLC

gst-launch-1.0 -v videotestsrc ! openh264enc entropy-coding=1 !
video/x-h264,profile=high ! fakesink

will produce high profile with cabac entropy coding

gst-launch-1.0 -v videotestsrc ! openh264enc entropy-coding=0 !
video/x-h264,profile=high ! fakesink

will produce high profile with cavlc entropy coding.

Regarding openh264 < 1.4

1) GST_OPENH264_CABAC so the property cannot be setted
2) in negotiate method, negotiation is not allowed and so the profile is setted
to baseline since cavlc is the only option

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.