[Bug 640610] basesink: QoS events are wrong in live pipelines

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=640610

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #314690|none                        |reviewed
             status|                            |

--- Comment #24 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 314690:
 --> (https://bugzilla.gnome.org/review?bug=640610&attachment=314690)

::: libs/gst/base/gstbasesink.c
@@ +545,3 @@
+   * for processing the buffer. This is added to the latency of live
+   * pipelines.
+   */

Since: 1.8

Maybe explain when you would want to use that, especially compared to
max-lateness.

@@ +1404,3 @@
+ * Maximum amount of time (in nanoseconds) that the pipeline can take
+ * for processing the buffer. This is added to the latency of live
+ * pipelines.

How would a subclass decide on a good value for this? Based on how much time it
thinks it will take to get buffers from render() to the display? Or prepare()
to render()?

@@ +1406,3 @@
+ * pipelines.
+ *
+ * This function is usually called by subclasses.

Since: 1.8

@@ +1437,3 @@
+ * the processing deadline.
+ *
+ * Returns: the processing deadline

Since: 1.8

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.