[Bug 757419] openh264enc: add support for cabac entropy coding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757419

Nicola <lists at svrinformatica.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #314628|0                           |1
        is obsolete|                            |

--- Comment #6 from Nicola <lists at svrinformatica.it> ---
Created attachment 314700
  --> https://bugzilla.gnome.org/attachment.cgi?id=314700&action=edit
patch v3

Minor modification, test with openh264 1.4 too, here are the results

gst-inspect-1.0 openh264enc
....
....
entropy-coding      : Entropy coding mode. CABAC mode require openh264 1.5 or
better
                        flags: readable, writable
                        Enum "GstOpenh264encEntropyCodingMode" Default: 0,
"CAVLC"
                           (0): CAVLC            - Context-adaptive
variable-length coding

so only CAVLC is possibile

gst-launch-1.0 -v videotestsrc ! openh264enc entropy-coding=1 ! fakesink

0:00:00.025827574 26595      0x163ea70 ERROR           GST_PIPELINE
grammar.y:454:gst_parse_element_set: could not set property "entropy-coding" in
element "openh264enc0" to "1"
WARNING: erroneous pipeline: could not set property "entropy-coding" in element
"openh264enc0" to "1"

and no downstream caps negotiation is possibile (as before this patch)

gst-launch-1.0 -v videotestsrc ! openh264enc entropy-coding=0 !
video/x-h264,profile=high ! fakesink

...
gstbasesrc.c(2943): gst_base_src_loop ():
/GstPipeline:pipeline0/GstVideoTestSrc:videotestsrc0:
streaming task paused, reason not-negotiated (-4)
...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.