[Bug 747482] waylandsink: need exception code in gst_wayland_sink_set_window_handle() and gst_wayland_sink_set_context()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747482

Luis de Bethencourt <luis at debethencourt.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301176|needs-work                  |committed
             status|                            |

--- Comment #7 from Luis de Bethencourt <luis at debethencourt.com> ---
Review of attachment 301176:
 --> (https://bugzilla.gnome.org/review?bug=747482&attachment=301176)

Sorry this got lost in the noise until now.

I split it into 2 patches since it is two different changes. Each commit should
be one atomic fix.
I also fixed the commit message, so you can see the format for your next
contribution :)

Thanks for the fix!

commit c9aaa4189b147314129e67adb0e20c1275c19051
Author: Hyunil Park <hyunil46.park at samsung.com>
Date:   Tue Nov 3 10:42:40 2015 +0000

    waylandsink: Add exception code for setting wl_surface

    Waylandsink needs exception code in gst_wayland_sink_set_window_handle().
    After making sink->window, User can call
    gst_wayland_sink_set_window_handle(). It is the user's fault, but
    Waylandsink needs to handle the exception, if not then sink->window is
    changed and rendering fails.

    https://bugzilla.gnome.org/show_bug.cgi?id=747482

commit d3db3df320de4a8450d2c23039d99dd0a0ddcca9
Author: Hyunil Park <hyunil46.park at samsung.com>
Date:   Thu Apr 9 13:17:01 2015 +0900

    waylandsink: Add exception code for setting wl_display

    Waylandsink needs exception code in gst_wayland_sink_set_context(). After
    calling gst_wayland_sink_set_context(), below code is set.
    GST_ELEMENT_CLASS (parent_class)->set_context (element, context); but, If
    user can call onemore. It is user's fault. but waylandsink need to
    exception.

    https://bugzilla.gnome.org/show_bug.cgi?id=747482

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.