[Bug 755319] configure: add --with-hls-crypto=auto|nettle|libgcrypt|openssl option

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Nov 4 15:30:21 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755319

Julian Bouzas <nnoell3 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #314847|reviewed                    |none
             status|                            |
 Attachment #314847|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Bouzas <nnoell3 at gmail.com> ---
Created attachment 314861
  --> https://bugzilla.gnome.org/attachment.cgi?id=314861&action=edit
Patch that adds --with-hls-crypto=auto|nettle|libgcrypt|openssl option

Hi Sebastian,

Thanks for your review. I totally agree that the indentation looks ugly with so
many AS_IF, but unfortunately, the logic is quite complex in that particular
case. I Added an AS_CASE as you suggested and it definitely looks better.

I also tried to remove duplicate checks by doing something like:

    if ( with_hls_crypto=="nettle" || (with_hls_crypto=="auto" &&
PKG_CHECK_MODULES("nettle")) ) {
    } else if...

but, as far as I can tell, I think it is not possible to *compose* an AS_IF
with a PKG_CHECK_MODULES together. To be honest, I am not really familiar with
M4 and there is not much documentation out there :(

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list