[Bug 745151] videofilter: add sharpening filter

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745151

Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #314905|none                        |needs-work
             status|                            |

--- Comment #19 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> ---
Review of attachment 314905:
 --> (https://bugzilla.gnome.org/review?bug=745151&attachment=314905)

Minor formatting comments

::: gst/videofilters/gstvideobaseconvolvefilter.c
@@ +106,3 @@
+          inc = 0;
+          for (k = 0; k < fh; k++) {
+            if ((i < fh_mid) || ((i + k) >= (h - 1)))

Drop the unneeded parenthesis

@@ +107,3 @@
+          for (k = 0; k < fh; k++) {
+            if ((i < fh_mid) || ((i + k) >= (h - 1)))
+              index = (i * stride + j);

ditto

@@ +114,3 @@
+              fIndex = k * kernel->w + l;
+              inc += (pData[index + c] * kernel->va[fIndex]);
+              cnt += (kernel->va[fIndex]);

ditto

@@ +206,3 @@
+          incR = incG = incB = 0;
+          for (k = 0; k < fh; k++) {
+            if ((i < fh_mid) || ((i + k) >= (h - 1)))

here too

@@ +207,3 @@
+          for (k = 0; k < fh; k++) {
+            if ((i < fh_mid) || ((i + k) >= (h - 1)))
+              index = (i * stride + j * components);

ditto

@@ +215,3 @@
+              incR += (pData[index + c] * kernel->va[fIndex]);
+              incG += (pData[index + c + 1] * kernel->va[fIndex]);
+              incB += (pData[index + c + 2] * kernel->va[fIndex]);

again

@@ +217,3 @@
+              incB += (pData[index + c + 2] * kernel->va[fIndex]);
+              cnt += (kernel->va[fIndex]);
+              if ((j < fw_mid) || ((j + l) >= (w - 1)))

and again

@@ +227,3 @@
+          outcR = (incR / cnt);
+          outcG = (incG / cnt);
+          outcB = (incB / cnt);

and again

@@ +280,3 @@
+      inc = 0;
+      for (k = 0; k < fh; k++) {
+        if ((i < fh_mid) || ((i + k) >= (h - 1)))

yet another time

@@ +283,3 @@
+          index = (i * stride + j);
+        else
+          index = ((i + k) * stride + j);

again

@@ +289,3 @@
+          inc += (pData[index + c] * kernel->va[fIndex]);
+          cnt += (kernel->va[fIndex]);
+          if ((j < fw_mid) || ((j + l) >= (w - 1)))

again

@@ +357,3 @@
+  } else if (GST_VIDEO_INFO_IS_GRAY (&input->info)) {
+    return gst_video_base_convolve_GRAY (video_filter, input, output);
+  } else

feel free to drop the braces for single statements

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.