[Bug 731791] videometa: add GstVideoAffineTransformationMeta

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 10 01:22:28 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=731791

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315174|none                        |accepted-commit_now
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315174:
 --> (https://bugzilla.gnome.org/review?bug=731791&attachment=315174)

Go ahead, just some minor things to clean up before pushing :)

Please also add it to the docs and the win32 .def files (run make check-exports
for the latter).

::: gst-libs/gst/video/gstvideoaffinetransformationmeta.c
@@ +29,3 @@
+  static volatile GType type = 0;
+  static const gchar *tags[] =
+      { GST_META_TAG_VIDEO_STR, GST_META_TAG_VIDEO_ORIENTATION_STR, NULL };

And video-dimensions I guess. If you scale, anything that uses absolute pixel
coordinates also needs to be updated

@@ +103,3 @@
+ * the given parameters.
+ *
+ * Returns: the #GstVideoAffineTransformationMeta on @buffer.

Since: 1.8
Also for everything else

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list