[Bug 757892] rtph264pay: send PPS/SPS before every key frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757892

--- Comment #2 from Anton Bondarenko <antonbo at axis.com> ---
(In reply to Olivier Crête from comment #1)
> Review of attachment 315192 [details] [review]:
> 
> ::: gst/rtp/gstrtph264pay.c
> @@ -125,3 @@
>    g_object_class_install_property (G_OBJECT_CLASS (klass),
>        PROP_CONFIG_INTERVAL,
> -      g_param_spec_uint ("config-interval",
> 
> That's an API change, it's not allowed. I suggest just using G_MAXUINT
> instead or something like that

Olivier,

I agree, this is an API change. But I think this is the minimal possible change
and a bit more logical. Ideally would be to use "config-interval" equal to 0,
but this is already defined as "disable". So now we have to choose between -1
and G_MAXUINT.

The property itself was defined as integer with valid range from 0 to 3600
before. So to make G_MAXUINT valid we must allow all other values from 3601 to
G_MAXUINT. One the other hand changing property storage from "unsigned int" to
"signed int" is element internal implementation details and does not affect API
since value is still should be in range from 0 to 3600. In this case we can
extend min_value to -1 while keeping old numbers with same meaning.

Another way is to introduce a new property like "config-mode" with options
"interval", "disable", "always" and default value "interval". But this could
make things a bit more complicated, since now we have 2 ways to disable PPS/SPS
send. Set "config-interval" to 0 or set "config-mode" to "disable".

So what do you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.